Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose onion_message items directly rather than via re-exports #2821

Merged

Commits on Jan 10, 2024

  1. Expose onion_message items directly rather than via re-exports

    When we originally added the `onion_message` module, there weren't
    a lot of public items in it, and it didn't make a lot of sense to
    export the whole sub-module structure publicly. So, instead, we
    exported the public items via re-exports directly in the
    `onion_message` top-level module. However, as time went on, more
    and more things entered the module, which left the top-level module
    rather cluttered.
    
    Worse, in 0.0.119, we exposed
    `onion_message::messenger::SendSuccess` via the return type of
    `send_message`, but forgot to re-export the enum itself, making
    it impossible to actually use from external code.
    
    Here we address both issues and simply replace the re-export with
    the underlying sub-module structure.
    TheBlueMatt committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    ab66143 View commit details
    Browse the repository at this point in the history