Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop PeerManager type bound on UtxoLookup entirely #2822

Merged
merged 1 commit into from
Jan 11, 2024

Commits on Jan 10, 2024

  1. Drop PeerManager type bound on UtxoLookup entirely

    In 6765967 we relaxed the bounds
    set on `UtxoLookup` to enable those using `RoutingMessageHandler`
    other than `P2PGossipSync` to use `UtxoLookup`. Sadly, because this
    requires having a concrete `PeerManager` type which does *not* use
    `UtxoLookup` in the `RoutingMessageHandler` type, this broke users
    who were directly using `P2PGossipSync`.
    
    We could split `UtxoLookup` into two, with different bounds, for
    the two use-cases, but instead here we simply switch to storing a
    reference to the `PeerManager` via a `dyn Fn` which allows us to
    wake the `PeerManager` when we need to.
    
    Fixes lightningdevkit#2813
    TheBlueMatt committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    3703399 View commit details
    Browse the repository at this point in the history