Drop PeerManager type bound on UtxoLookup entirely
#2822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 6765967 we relaxed the bounds set on `UtxoLookup` to enable those using `RoutingMessageHandler` other than `P2PGossipSync` to use `UtxoLookup`. Sadly, because this requires having a concrete `PeerManager` type which does *not* use `UtxoLookup` in the `RoutingMessageHandler` type, this broke users who were directly using `P2PGossipSync`. We could split `UtxoLookup` into two, with different bounds, for the two use-cases, but instead here we simply switch to storing a reference to the `PeerManager` via a `dyn Fn` which allows us to wake the `PeerManager` when we need to. Fixes lightningdevkit#2813
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2822 +/- ##
==========================================
+ Coverage 88.49% 89.19% +0.69%
==========================================
Files 114 114
Lines 91935 98339 +6404
Branches 91935 98339 +6404
==========================================
+ Hits 81359 87714 +6355
- Misses 8097 8202 +105
+ Partials 2479 2423 -56 ☔ View full report in Codecov by Sentry. |
wpaulino
approved these changes
Jan 11, 2024
tnull
reviewed
Jan 11, 2024
tnull
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 6765967 we relaxed the bounds set on
UtxoLookupto enable those usingRoutingMessageHandlerother thanP2PGossipSyncto useUtxoLookup. Sadly, because this requires having a concretePeerManagertype which does not useUtxoLookupin theRoutingMessageHandlertype, this broke users who were directly usingP2PGossipSync.We could split
UtxoLookupinto two, with different bounds, for the two use-cases, but instead here we simply switch to storing a reference to thePeerManagervia adyn Fnwhich allows us to wake thePeerManagerwhen we need to.Fixes #2813