Fix ser for PaymentRelay and PaymentConstraints
#2936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two fields were serialized as u32/u64 when the spec said *tu32/tu64*. /facepalm.
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2936 +/- ##
==========================================
+ Coverage 88.55% 91.19% +2.64%
==========================================
Files 115 118 +3
Lines 92309 110658 +18349
Branches 92309 110658 +18349
==========================================
+ Hits 81745 100917 +19172
+ Misses 8063 7345 -718
+ Partials 2501 2396 -105 ☔ View full report in Codecov by Sentry. |
jkczyz
approved these changes
Mar 14, 2024
TheBlueMatt
approved these changes
Mar 18, 2024
| ## Bug fixes | ||
|
|
||
| * LDK previously serialized `PaymentRelay::fee_base_msat` as a u32 when it | ||
| should have been serialized as a tu32. Similarly, we were serializing |
There was a problem hiding this comment.
Lets not write release notes with the technical internal details, but rather focus on the resulting behavior that is user-facing.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two fields were serialized as u32/u64 when the spec says tu32/tu64.
This caused lack of interop when using CLN/Eclair as forwarding nodes for blinded payment paths.
H/t to @orbitalturtle for catching this! It's my bug, sorry y'all.