Signal GossipQuery support when using IgnoringMessagHandler
#2959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With its v24.02 release CLN made `GossipQueries` a required feature, leading to a incompatibility between LDK and CLN when using `IgnoringMessagHandler` as a `RoutingMessageHandler`, which is usually the case when a node uses RGS. To fix this issue, we let `IgnoringMessagHandler` signal `GossipQuery` support, just to go ahead and ignore every gossip message the peer will send us. While this is nonsensical and still might result in some unnecessary bandwidth wasted, we have to do something to fix the incompatibility.
tnull
force-pushed
the
2024-03-support-gossip-queries-in-ignoring-handler
branch
from
770f5bf
to
843079d
Compare
|
Following, |
No, but I left a comment on the corresponding BOLTs PR: lightning/bolts#1092 (comment) |
|
@TheBlueMatt Even though the feature will be repurposed now and CLN reverted requiring it, I still wonder if we should still land this in 0.0.122 but revert it in 0.0.123 or 0.0.124 to fix the compatibility issues with current CLN versions in the meantime? |
TheBlueMatt
approved these changes
Mar 26, 2024
G8XSU
approved these changes
Mar 26, 2024
Now tracking in #2972 so we don't forget. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With its v24.02 release CLN made
GossipQueriesa required feature (see ElementsProject/lightning#6864 and https://github.com/ElementsProject/lightning/blob/master/CHANGELOG.md#2402---2024-02-27-uint-needs-signature), leading to a incompatibility between LDK and CLN when usingIgnoringMessagHandleras aRoutingMessageHandler, which is usually the case when a node uses RGS.To fix this issue, we let
IgnoringMessagHandlersignalGossipQuerysupport, just to go ahead and ignore every gossip message the peer will send us. While this is nonsensical and still might result in some unnecessary bandwidth wasted, we have to do something to fix the incompatibility.