Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AChannelManager in BackgroundProcessor #2963

Merged
merged 3 commits into from
Mar 25, 2024

Conversation

jkczyz
Copy link
Contributor

@jkczyz jkczyz commented Mar 23, 2024

Replace instance of ChannelManager in BackgroundProcessor and inPersister with AChannelManager. This reduces the number of type parameters need in those types, which would need to be repeated in an async version of Persister.

Replace instance of ChannelManager in BackgroundProcessor and in
Persister with AChannelManager. This reduces the number of type
parameters need in those types, which would need to be repeated in an
async version of Persister.
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 83.33333% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 90.21%. Comparing base (670b41a) to head (d29e2ba).
Report is 68 commits behind head on main.

Files Patch % Lines
lightning/src/util/persist.rs 50.00% 2 Missing ⚠️
lightning-background-processor/src/lib.rs 92.85% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2963      +/-   ##
==========================================
+ Coverage   89.11%   90.21%   +1.10%     
==========================================
  Files         117      117              
  Lines       95029   101020    +5991     
  Branches    95029   101020    +5991     
==========================================
+ Hits        84685    91140    +6455     
+ Misses       7856     7597     -259     
+ Partials     2488     2283     -205     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested LDK Node tests pass based on this.

@tnull tnull merged commit b8b1ef3 into lightningdevkit:main Mar 25, 2024
12 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants