Remove WriteableEcdsaChannelSigner trait
#3059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkczyz
force-pushed
the
2024-05-drop-writeable-signer
branch
from
75100e3
to
4ad3401
Compare
TheBlueMatt
previously approved these changes
May 10, 2024
4 tasks
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3059 +/- ##
==========================================
- Coverage 89.81% 89.79% -0.03%
==========================================
Files 116 116
Lines 96472 96465 -7
Branches 96472 96465 -7
==========================================
- Hits 86647 86616 -31
- Misses 7258 7292 +34
+ Partials 2567 2557 -10 ☔ View full report in Codecov by Sentry. |
iiuc, it should be 113. |
jkczyz
force-pushed
the
2024-05-drop-writeable-signer
branch
from
4ad3401
to
e76966a
Compare
Corrected! |
G8XSU
previously approved these changes
May 10, 2024
EcdsaChannelSigner is no longer deserialized as of version 0.0.113 and downgrades before version 0.0.113 are no longer supported as of version 0.0.119.
WriteableEcdsaChannelSigner is no longer needed now that EcdsaChannelSigner isn't written in OnchainTxHandler.
jkczyz
force-pushed
the
2024-05-drop-writeable-signer
branch
from
e76966a
to
efc7579
Compare
|
Sorry, latest push just fixed some grammar |
TheBlueMatt
approved these changes
May 10, 2024
G8XSU
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EcdsaChannelSigneris no longer deserialized as of version 0.0.113 and downgrades before version 0.0.113 are no longer supported as of version 0.0.119. Stop writing it and remove theWriteableEcdsaChannelSignertrait.Closes #3053.