Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache commitment point on ExternalHTLCClaim to drop a signer call #3096

Merged

Conversation

alecchendev
Copy link
Contributor

Small standalone change that will also help make things simpler for async signing.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.66%. Comparing base (df01208) to head (4c1638c).
Report is 51 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3096      +/-   ##
==========================================
+ Coverage   89.90%   91.66%   +1.75%     
==========================================
  Files         117      119       +2     
  Lines       97105   112257   +15152     
  Branches    97105   112257   +15152     
==========================================
+ Hits        87303   102901   +15598     
+ Misses       7243     7085     -158     
+ Partials     2559     2271     -288     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arik-so arik-so merged commit 1e49c4a into lightningdevkit:main Jun 7, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants