Pre-C Bindings Cleanup #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBlueMatt
force-pushed
the
2020-05-pre-bindings-cleanups
branch
3 times, most recently
from
cd8520e
to
8f23cf4
Compare
Codecov Report
@@ Coverage Diff @@
## master #620 +/- ##
==========================================
+ Coverage 91.29% 91.35% +0.06%
==========================================
Files 35 35
Lines 20776 20775 -1
==========================================
+ Hits 18967 18979 +12
+ Misses 1809 1796 -13
Continue to review full report at Codecov.
|
jkczyz
reviewed
May 12, 2020
Comment on lines
+762
to
+773
| /// The concrete type which signs for transactions and provides access to our channel public | ||
| /// keys. | ||
| type Keys: ChannelKeys; |
There was a problem hiding this comment.
s/which/that
Or how about simply "Keys needed to operate the monitored channels."?
There was a problem hiding this comment.
We're slowly moving away from it being keys and more towards it being an interface which signs for things (eg a hardware wallet).
TheBlueMatt
force-pushed
the
2020-05-pre-bindings-cleanups
branch
2 times, most recently
from
5b81cc6
to
1523501
Compare
This makes it easier for our automated bindings generator to function as it tries to automatically create a ::new if the struct contains only pub elements who's type is convertible.
|
Looks good but needs rebase |
TheBlueMatt
force-pushed
the
2020-05-pre-bindings-cleanups
branch
from
1523501
to
7411aad
Compare
ariard
reviewed
May 18, 2020
| @@ -172,41 +174,105 @@ impl events::MessageSendEventsProvider for TestChannelMessageHandler { | |||
| } | |||
| } | |||
|
|
|||
| fn get_dummy_channel_announcement(short_chan_id: u64) -> msgs::ChannelAnnouncement { | |||
There was a problem hiding this comment.
Test helpers move could have been commented in commit or at least splitted to ease review. That's okay AFAICT, they don't break anything.
There was a problem hiding this comment.
I just commented it in the commit.
Instead of using a raw generic type, an associted type allows us to have explicit docs on the type, which is nice. More importantly, however, our automated bindings generator knows how to read associated types but not raw generics. Also, our bindings generator expects things which are referenced to have already been defined, so we move ManyChannelMonitor below the ChannelMonitor definition.
We also update to use single idents when referencing the Deref=* types since the automated code generator is pretty braindead. This also moves some test utils out of peer_handler.rs and into util::test_utils to standardize things a little bit, which we need to concretize the PeerHandler types used in testing.
We never actually fail, so we can just drop the Result type.
* Return Self instead of the fully-written types for constructors, * Place definitions before use (in this case for KeysInterface), * Don't import foo::bar::self, but import foo::bar + a spelling fix in the KeysInterface docs for get_onion_rand.
Its just a trivial bool and already has docs on it, so seems like an oversight
TheBlueMatt
force-pushed
the
2020-05-pre-bindings-cleanups
branch
from
7411aad
to
ba06507
Compare
jkczyz
approved these changes
May 25, 2020
|
Gonna take this since we already did the review cycles, but there will be more before bindings land. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is some of the groundwork needed for #618, but which is generally applicable. Most of the cleanups are also slightly cleaner code, so easy to land this before.