-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename a's keys as local's keys and b's keys as remote's keys #633
Rename a's keys as local's keys and b's keys as remote's keys #633
Commits on Sep 11, 2020
-
Change variable nomenclature in chan_utils
Variables should be named according to the script semantic which is an invariant with regards to generating a local or remote commitment transaction. I.e a broadcaster_htlc_key will always guard a HTLC to the party able to broadcast the computed transactions whereas countersignatory_htlc_key will guard HTLC to a countersignatory of the commitment transaction.
Antoine Riard committedSep 11, 2020 Configuration menu - View commit details
-
Copy full SHA for 1d7c4f6 - Browse repository at this point
Copy the full SHA 1d7c4f6View commit details
Commits on Sep 14, 2020
-
Change variable nomenclature for Channel fields
Previously most of variable fields relative to data belonging to our node or counterparty were labeled "local"/"remote". It has been deemed confusing with regards to transaction construction which is always done from a "local" viewpoint, even if owner is our counterparty
Antoine Riard committedSep 14, 2020 Configuration menu - View commit details
-
Copy full SHA for c7ef6df - Browse repository at this point
Copy the full SHA c7ef6dfView commit details -
Change variable nomenclature for to_self_delay
To avoid reviewers confusion, rename counterparty_to_self_delay to counteparty_selected_contest_delay, i.e the justice delay announced by a channel counterparty restraining our transactions, and to_self_delay to locally_selected_contest_delay, i.e the justice delay announced by us restraining counterparty's transactions We deviate from wider nomenclature by prefixing local data with a locally_ extension due to the leak of this value in transactions/scripts builder, where the confusion may happen. Rename further AcceptChannelData to the new nomenclature.
Antoine Riard committedSep 14, 2020 Configuration menu - View commit details
-
Copy full SHA for c6a91f2 - Browse repository at this point
Copy the full SHA c6a91f2View commit details -
Underscore TxCreationKeys ownership
A TxCreationKeys set represents the key which will be embedded in output scripts of a party's commitment tx state. Among them there is a always a key belonging to counter-party, the HTLC pubkey. To dissociate strongly, prefix keys with broadcaster/countersignatory. A revocation keypair is attributed to the broadcaster as it's used to punish a fraudulent broadcast while minding that such keypair derivation method will be always used by countersignatory as it's its task to enforce punishement thanks to the release secret.
Antoine Riard committedSep 14, 2020 Configuration menu - View commit details
-
Copy full SHA for b51721f - Browse repository at this point
Copy the full SHA b51721fView commit details -
Change ChannelKeys interface nomenclature to holder/counterparty one
Transaction signing methods are changed from local_/remote_ prefix to newer holder_/counterparty_ wihout any semantic changes.
Antoine Riard committedSep 14, 2020 Configuration menu - View commit details
-
Copy full SHA for 9a23130 - Browse repository at this point
Copy the full SHA 9a23130View commit details -
Overhaul ChannelMonitor/OnchainTxHandler to new nomenclature
Antoine Riard committedSep 14, 2020 Configuration menu - View commit details
-
Copy full SHA for 00d063d - Browse repository at this point
Copy the full SHA 00d063dView commit details -
Overhaul LocalCommitmentTx to new nomenclature
Antoine Riard committedSep 14, 2020 Configuration menu - View commit details
-
Copy full SHA for 6133498 - Browse repository at this point
Copy the full SHA 6133498View commit details -
Cleanup locally-selected-delay
Comment meaning of holder/counterparty Diverse chan_utils cleanups Cleanups post-cbindings merge Fix misusage of holder_selected_contest_delay instead of counterparty _selected_contest_delay in HolderCommitmentTransaction Fix old payment_point comment
Antoine Riard committedSep 14, 2020 Configuration menu - View commit details
-
Copy full SHA for 21d0a95 - Browse repository at this point
Copy the full SHA 21d0a95View commit details