Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BOLT 3 test vector for CLTV tiebreaker #771

Merged
merged 1 commit into from
Jan 13, 2021

Conversation

jkczyz
Copy link
Contributor

@jkczyz jkczyz commented Jan 8, 2021

The test vector was added in lightning/bolts#539.

@codecov
Copy link

codecov bot commented Jan 8, 2021

Codecov Report

Merging #771 (e58e73f) into main (9c9c881) will decrease coverage by 0.12%.
The diff coverage is 88.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #771      +/-   ##
==========================================
- Coverage   91.35%   91.22%   -0.13%     
==========================================
  Files          37       37              
  Lines       22791    22866      +75     
==========================================
+ Hits        20821    20860      +39     
- Misses       1970     2006      +36     
Impacted Files Coverage Δ
lightning/src/chain/keysinterface.rs 93.33% <0.00%> (-0.86%) ⬇️
lightning/src/lib.rs 100.00% <ø> (ø)
lightning/src/util/config.rs 50.00% <50.00%> (-19.05%) ⬇️
lightning/src/util/test_utils.rs 83.68% <66.66%> (-1.16%) ⬇️
lightning/src/ln/channel.rs 87.49% <86.95%> (-0.03%) ⬇️
lightning/src/chain/channelmonitor.rs 95.67% <100.00%> (+0.09%) ⬆️
lightning/src/ln/chanmon_update_fail_tests.rs 97.56% <100.00%> (ø)
lightning/src/ln/channelmanager.rs 84.94% <100.00%> (ø)
lightning/src/ln/functional_test_utils.rs 95.13% <100.00%> (ø)
lightning/src/ln/functional_tests.rs 96.91% <100.00%> (-0.27%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c9c881...caa16e0. Read the comment docs.

@jkczyz
Copy link
Contributor Author

jkczyz commented Jan 8, 2021

Tested by removing the tiebreaker and seeing a test failure.

Copy link
Collaborator

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we only take one of the new tests when it looks like the spec PR has several tests?

@jkczyz
Copy link
Contributor Author

jkczyz commented Jan 13, 2021

Why did we only take one of the new tests when it looks like the spec PR has several tests?

The spec PR only adds one new test vector. However, it was updated to include all test vectors for use with option_static_remotekey which we already moved to in babf0af.

@TheBlueMatt TheBlueMatt merged commit d529a88 into lightningdevkit:main Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants