Skip to content

Commit

Permalink
build: update NodeJS to v16 in CI builds
Browse files Browse the repository at this point in the history
  • Loading branch information
jamaljsr committed Apr 4, 2022
1 parent 0a8c060 commit 0233f27
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 20 deletions.
14 changes: 7 additions & 7 deletions .github/workflows/main.yml
Expand Up @@ -24,7 +24,7 @@ jobs:

strategy:
matrix:
node_version: [12.x]
node_version: [16.x]
os: [ubuntu-latest, windows-latest, macOS-latest]

steps:
Expand Down Expand Up @@ -109,10 +109,10 @@ jobs:
id: yarn-cache
with:
path: ${{ steps.yarn-cache-dir.outputs.dir }}
key: ${{ runner.os }}-yarn-12.x-${{ hashFiles('**/yarn.lock') }}
key: ${{ runner.os }}-yarn-16.x-${{ hashFiles('**/yarn.lock') }}
restore-keys: |
${{ runner.os }}-yarn-12.x-${{ hashFiles('**/yarn.lock') }}
${{ runner.os }}-yarn-12.x-
${{ runner.os }}-yarn-16.x-${{ hashFiles('**/yarn.lock') }}
${{ runner.os }}-yarn-16.x-
${{ runner.os }}-yarn-
- name: setup go v${{ matrix.go_version }}
Expand All @@ -138,10 +138,10 @@ jobs:
- name: git checkout
uses: actions/checkout@v2

- name: setup nodejs v${{ matrix.node_version }}
- name: setup nodejs v16.x
uses: actions/setup-node@v1
with:
node-version: 12.x
node-version: 16.x

- name: download cache
uses: actions/cache@v1
Expand Down Expand Up @@ -192,7 +192,7 @@ jobs:
- name: setup nodejs v${{ matrix.node_version }}
uses: actions/setup-node@v1
with:
node-version: 12.x
node-version: 16.x

- name: download cache
uses: actions/cache@v1
Expand Down
14 changes: 7 additions & 7 deletions Dockerfile
@@ -1,5 +1,5 @@
# Start with a NodeJS base image that also contains yarn.
FROM node:12.17.0-alpine as nodejsbuilder
FROM node:16.14.2-alpine as nodejsbuilder

# Pass a tag, branch or a commit using build-arg. This allows a docker image to
# be built from a specified Git state. The default image will use the Git tip of
Expand All @@ -20,8 +20,8 @@ ARG public_url=""
# be mitigated by switching to HTTP and increasing the network timeout.
# See https://github.com/yarnpkg/yarn/issues/5259 for more info.
RUN apk add --no-cache --update alpine-sdk \
python \
git \
python \
git \
&& git clone https://github.com/lightninglabs/lightning-terminal /go/src/github.com/lightninglabs/lightning-terminal \
&& cd /go/src/github.com/lightninglabs/lightning-terminal \
&& git checkout $checkout \
Expand Down Expand Up @@ -51,7 +51,7 @@ ENV GO111MODULE on

# Install dependencies and install/build lightning-terminal.
RUN apk add --no-cache --update alpine-sdk \
make \
make \
&& cd /go/src/github.com/lightninglabs/lightning-terminal \
&& make go-install PUBLIC_URL=$public_url \
&& make go-install-cli
Expand All @@ -75,9 +75,9 @@ COPY --from=golangbuilder /go/bin/pool /bin/

# Add bash.
RUN apk add --no-cache \
bash \
jq \
ca-certificates
bash \
jq \
ca-certificates

# Specify the start command and entrypoint as the lightning-terminal daemon.
ENTRYPOINT ["litd"]
10 changes: 5 additions & 5 deletions dev.Dockerfile
@@ -1,5 +1,5 @@
# Start with a NodeJS base image that also contains yarn.
FROM node:12.17.0-alpine as nodejsbuilder
FROM node:16.14.2-alpine as nodejsbuilder

# Copy in the local repository to build from.
COPY . /go/src/github.com/lightninglabs/lightning-terminal
Expand Down Expand Up @@ -28,7 +28,7 @@ ENV GO111MODULE on

# Install dependencies and install/build lightning-terminal.
RUN apk add --no-cache --update alpine-sdk \
make \
make \
&& cd /go/src/github.com/lightninglabs/lightning-terminal \
&& make go-install \
&& make go-install-cli
Expand All @@ -52,9 +52,9 @@ COPY --from=golangbuilder /go/bin/pool /bin/

# Add bash.
RUN apk add --no-cache \
bash \
jq \
ca-certificates
bash \
jq \
ca-certificates

# Specify the start command and entrypoint as the lightning-terminal daemon.
ENTRYPOINT ["litd"]
2 changes: 1 addition & 1 deletion proto/Dockerfile
@@ -1,5 +1,5 @@
# Start with a NodeJS base image that also contains yarn.
FROM node:12.17.0-buster as nodejsbuilder
FROM node:16.14.2-buster as nodejsbuilder

RUN apt-get update && apt-get install -y \
git \
Expand Down

0 comments on commit 0233f27

Please sign in to comment.