Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accounts: don't error out on payment not initiated #640

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

guggero
Copy link
Member

@guggero guggero commented Sep 5, 2023

Fixes #638.

It can happen that we see the payment request for a payment coming in, register it, but then it is failed on the lnd level and basically never exists in the DB.
In that case we can just stop tracking the payment.

Copy link
Member

@ellemouton ellemouton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Copy link
Contributor

@ViktorTigerstrom ViktorTigerstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well :)!

It can happen that we see the payment request for a payment coming in,
register it, but then it is failed on the lnd level and basically never
exists in the DB.
In that case we can just stop tracking the payment.
@guggero guggero merged commit dfb4fff into master Sep 6, 2023
12 checks passed
@guggero guggero deleted the fix-payment-not-initiated branch September 6, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LITD: Received critical error from subsystem, shutting down: payment isn't initiated
3 participants