Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

accounts: fix service check in UpdateAccounts call #651

Merged
merged 1 commit into from
Oct 11, 2023
Merged

accounts: fix service check in UpdateAccounts call #651

merged 1 commit into from
Oct 11, 2023

Conversation

GeorgeTsagk
Copy link
Member

Description

This PR fixes a simple check in the UpdateAccount RPC handler which checks if the service is running.

@GeorgeTsagk GeorgeTsagk self-assigned this Oct 11, 2023
guggero
guggero approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! LGTM 🎉

ViktorTigerstrom
ViktorTigerstrom approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@ViktorTigerstrom ViktorTigerstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh snap, my bad 😬... Thanks a lot for the fix 🎉! LGTM

@guggero guggero merged commit 13bea90 into lightninglabs:master Oct 11, 2023
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guggero guggero guggero approved these changes

@ViktorTigerstrom ViktorTigerstrom ViktorTigerstrom approved these changes

Assignees

@GeorgeTsagk GeorgeTsagk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GeorgeTsagk @guggero @ViktorTigerstrom