status: apply functional options on subServer init #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViktorTigerstrom
requested review from
ellemouton and
guggero
and removed request for
ellemouton
guggero
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #694 we added support for initialising the
subServerstruct with functional options. Unfortunately though, with the last refactors in the PR I forgot to also apply the functional options insubServerconstructor function. Sorry for that, this was totally my bad! The current resulting behaviour is that thelitcli statuswon't function as expected forlnd, whilelndSubserver is in theWalletReadystate (until it enters theRunningstate).This PR addresses the issue, and applies the functional options in the
subServerconstructor.