go.mod: update LND to v0.18.0-beta.1 #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the same as v0.18.0-beta.
guggero
reviewed
Jun 4, 2024
tools/Dockerfile
Outdated
| @@ -11,7 +11,7 @@ RUN cd /tmp \ | |||
| && mkdir -p /tmp/build/.cache \ | |||
| && mkdir -p /tmp/build/.modcache \ | |||
| && cd /tmp/tools \ | |||
| && go install -trimpath github.com/golangci/golangci-lint/cmd/golangci-lint \ | |||
| && go install -trimpath github.com/golangci/golangci-lint/cmd/golangci-lint@v1.59.0 \ | |||
There was a problem hiding this comment.
This should be updated in the go.mod file in the tools folder. That's the whole point of that go.mod file in the first place, that we can pin version numbers of our tooling binaries we want to use.
| @@ -319,7 +319,7 @@ func TestGetLndInfo(t *testing.T) { | |||
| require.Error(t, err) | |||
|
|
|||
| // Error might be wrapped. | |||
| require.True(t, errors.Is(err, test.expected)) | |||
| require.ErrorIs(t, err, test.expected) | |||
Update the image used to build to golang:1.22.3-bookworm. Updated the config: removed the linters that were removed, added new unconfigured linters creating a lot of noice, fixed one linter warning that made sense.
starius
force-pushed
the
lnd-v0.18.0-beta.1
branch
from
97107f5
to
81bbbea
Compare
guggero
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same as v0.18.0-beta.
Pull Request Checklist
in
lnd_services.goare updated.macaroon_recipes.goif your PR adds a new method that is calleddifferently than the RPC method it invokes.