blockmanager: address filter header tip lock inconsistency #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a previous assumption that filterHeaderTip and filterHeaderTipHash were only being accessed within the cfHandler goroutine. This is no longer the case, as we require the filter header tip in order to deliver a backlog of notifications for block notification subscribers. We also establish a locking order when needing to acquire both newHeadersMtx and newFilterHeadersMtx in certain cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a previous assumption that filterHeaderTip and filterHeaderTipHash were only being accessed within the cfHandler goroutine. This is no longer the case, as we require the filter header
tip in order to deliver a backlog of notifications for block notification subscribers.
We also establish a locking order when needing to acquire both newHeadersMtx and newFilterHeadersMtx in certain cases.
This attempts to address a deadlock found in this goroutine dump.