account+rpc: allow expiration update for existing accounts #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halseth
reviewed
Dec 2, 2020
Roasbeef
requested changes
Dec 9, 2020
We no longer need to track if the account expiry needs to be watched or not as the watcher now supports updating existing unfulfilled expiry requests.
Roasbeef
reviewed
Dec 15, 2020
halseth
suggested changes
Dec 15, 2020
halseth
suggested changes
Dec 17, 2020
This is an intermediate state where an account has met its expiration while having a pending update waiting for confirmation. The introduction of this state was necessary as the existing StateExpired state was not sufficient to handle all edge cases regarding account renewals. Now that this state exists, we can be sure renewals cannot happen until the account is both confirmed, unspent, and expired.
|
Replaced by #199. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows traders to update their account expiration after it has been created through the RPC/CLI interface. It also serves as groundwork for when we eventually allow automatic account renewals through batch participation. As a result of this functionality, a default of 30 days has been set going forward for all new accounts created, and can be overwritten if necessary.
Fixes #8.
Fixes #39.
Fixes #160.