-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug]: Regression: Missing newline in "Shutdown complete" log message #8713
Comments
Seems like there is a new line there already? Line 142 in ab83343
|
It's in the code and, if I understand the logging library correctly, that's not even necessary. However, I've seen the bug manifest itself several times, but not everytime I stop lnd. |
I did reproduce the problem. Actually I tested from the version v0.17.2-beta to 0.18.0-beta.rc1. The only version that we have missing newline in "Shutdown complete" is the v0.17.3-beta, curiously since v.0.17.4-beta we have a blank line after "Shutdown complete". See the logs below. Version: 0.17.2-beta ------------------------------------------------------------------------------------------------------------------------ 2024-05-04 00:37:37.207 [INF] LTND: Shutting down... Version: 0.17.3-beta ---------------------------------------------------------------------------------------------------------------------- 2024-05-03 21:25:24.666 [INF] LTND: Shutting down... Version: v0.17.4-beta ----------------------------------------------------------------------------------------------------------------------- 2024-05-03 21:17:23.715 [INF] LTND: Shutting down... 2024-05-03 21:17:45.492 [WRN] LTND: open /root/.lnd/lnd.conf: no such file or directory Version: 0.17.5-beta ------------------------------------------------------------------------------------------------------------------------ 2024-05-04 00:50:37.076 [INF] LTND: Shutting down... 2024-05-04 00:50:44.836 [WRN] LTND: open /root/.lnd/lnd.conf: no such file or directory Version: 0.18.0-beta.rc1 ---------------------------------------------------------------------------------------------------------------------- 2024-05-04 00:43:17.174 [INF] LTND: Shutting down... 2024-05-04 00:43:26.850 [WRN] LTND: open /root/.lnd/lnd.conf: no such file or directory |
So, this seems to be a non-issue in the releases after 17.3 |
@saubyk Please reopen, I just reproduced the issue with v0.18.0-beta.rc1. Let me know what kind of information you need to debug this.
I'm starting/stopping/restarting lnd via systemd:
|
If I use
|
How are you viewing the logs if you are using systemd. Is it through lnd.log file located in the lnd's data directory? Or Can you check both and see if the logs appear the same way? I am assuming your lnd is built to output logs in the file and stdout. Also that journalctl outputs the logs from stdout. |
I'm using log files (lnd.log) only, no journalctl/syslog. In my lnd.service: |
I did the tests on previous comment using docker images and command "lncli stop" and the problem occurred only on version: 0.17.3-beta. See the logs below: v0.17.2-beta (there is no problem) ---------------------------------------------------------------------------------------------------------------- v0.17.3-beta ----------------------------------------------------------------------------------------------------------------------------------------------------- v0.17.4-beta ------------------------------------------------------------------------------------------------------------------------------------------------ v0.17.5-beta ------------------------------------------------------------------------------------------------------------------------------------------------- v0.18.0-beta.rc1 ------------------------------------------------------------------------------------------------------------------------------------------- |
Original Flaw2024-05-20 14:04:17.705 [WRN] LTND: Config 'bitcoin.active' is deprecated, please remove it Test after PR#87702024-05-20 15:59:47.298 [WRN] LTND: Config 'bitcoin.active' is deprecated, please remove it |
Meaning? |
As you opened the issue ... I thought that you might send your opinion on this tiny PR. |
It doesn't look like a fix to me (I don't see a regression test, and I don't see the original flaw). But if it works, that's great! |
I just included the original flaw and the test showing that it is fixed after the PR#8770. You can see it on the first message of the PR. Thanks. |
I understood how the resulting log lines look like, but I still don't understand why the original code is wrong. I prefer understanding the consequences of changing code, which isn't the case here. As said, if it works, that's great. |
I got it and agree with you. From my research there is no wrong code on LND, that’s why I did a workaround. |
@ellemouton I did the test with the master branch and the issue persists as you can see below:
Then I did the test and the issue is not present with #9083 as you can see below:
|
@MPins - awesome!!! thanks for testing 🎉 |
See #3801. This bug resurfaced with
v0.17.3-beta
or before:This is the output (in
lnd.log
) withlncli stop
(v0.17.3-beta) and then re-starting lnd (v0.18.0-beta.rc1).The text was updated successfully, but these errors were encountered: