lncli: improve error message for unlock commands #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halseth
suggested changes
May 7, 2018
cmd/lncli/commands.go
Outdated
| s, ok := status.FromError(err) | ||
|
|
||
| // If it's a command for the UnlockerService (like 'create' or | ||
| // 'unlock') but the wallet is already unlocked, then these methods |
There was a problem hiding this comment.
lines should be wrapped at 80 chars.
There was a problem hiding this comment.
They were, actually. But because of the three levels of indentation it looks like more in the GitHub diff view.
I wrapped the longest line anyway.
There was a problem hiding this comment.
Ok, I think the default tab width in my IDE is wrong, sorry. I‘ll re-format it again.
guggero
force-pushed
the
lncli-double-unlock
branch
2 times, most recently
from
d4eb77f
to
dfc2baa
Compare
guggero
force-pushed
the
lncli-double-unlock
branch
from
dfc2baa
to
8ce73b3
Compare
Roasbeef
approved these changes
May 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #1191, if you issue the
unlockorcreatecommand again after the wallet is already unlocked, you get a strange error message:This is because the
UnlockerServiceis shut down after successful unlock and therefore the unlock commands aren't recognized on the gRPC interface any more (status=Unimplemented).I improved the error message for this special case since the current message is very misleading.
Fixes #1191.