lncli: improve error message for unlock commands #1193
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #1191, if you issue the
unlock
orcreate
command again after the wallet is already unlocked, you get a strange error message:This is because the
UnlockerService
is shut down after successful unlock and therefore the unlock commands aren't recognized on the gRPC interface any more (status=Unimplemented).I improved the error message for this special case since the current message is very misleading.
Fixes #1191.