Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lnrpc: add new WalletKit sub-RPC server #2093

Merged
merged 7 commits into from
Dec 7, 2018
Merged

lnrpc: add new WalletKit sub-RPC server #2093

merged 7 commits into from
Dec 7, 2018

Commits on Dec 7, 2018

  1. lnrpc/walletrpc: add new sub-RPC server, the WalletKit 

    In this commit, we add a new sub-RPC server to the existing set of gRPC
servers. This new sub-RPC server is the WalletKit. It's a utility
toolkit that contains method which allow clients to perform common
interactions with a wallet such as getting a new address, or sending a
transaction. It also includes some supplementary actions such as fee
estimation.

One thing to note in the RPC file is that we _import_ the existing
signer.proto file in order to get at some existing proto definitions
which are useful in our use case.
    @Roasbeef
    Roasbeef committed Dec 7, 2018
    Configuration menu
    Copy the full SHA
    097b6f7 View commit details
    Browse the repository at this point in the history

  2. lnrpc/walletrpc: implement the WalletKitServer gRPC service 

    In this commit, we implement the newly defiend WalletKitServer gRPC
service. We use the same template w.r.t build tags as the existing
signrpc service.
    @Roasbeef
    Roasbeef committed Dec 7, 2018
    Configuration menu
    Copy the full SHA
    406fd2a View commit details
    Browse the repository at this point in the history

  3. chainregistry: add the keyRing and walletController to chainControl

    @Roasbeef
    Roasbeef committed Dec 7, 2018
    Configuration menu
    Copy the full SHA
    b492114 View commit details
    Browse the repository at this point in the history

  4. config: add a new entry for the WalletKit sub-RPC server to subRpcSer… 

    …verConfigs
    @Roasbeef
    Roasbeef committed Dec 7, 2018
    Configuration menu
    Copy the full SHA
    14ca3bb View commit details
    Browse the repository at this point in the history

  5. log: wire up the new WalletKit logger

    @Roasbeef
    Roasbeef committed Dec 7, 2018
    Configuration menu
    Copy the full SHA
    8446980 View commit details
    Browse the repository at this point in the history

  6. lnrpc: remove oneof from signrpc.KeyDescriptor

    @Roasbeef
    Roasbeef committed Dec 7, 2018
    Configuration menu
    Copy the full SHA
    273dee6 View commit details
    Browse the repository at this point in the history

  7. rpc: extend the admin macaroon with signer capabilities 

    In this commit, we extend the admin macaroon with signer capabilities in
order to allow it to be used with the new signer sub-server. As a
result, users will need to clear out their old macaroons in order to
have the new improved admin macaroon generated. In the future, we may
want to restructure the way the admin macaroon functions: rather than
white listing each of these entities and operations, we can instead add
a catch all capability. This capability will instead allow access to any
call, as each new call would be modified to permit this capabilities and
no others.
    @Roasbeef
    Roasbeef committed Dec 7, 2018
    Configuration menu
    Copy the full SHA
    363b992 View commit details
    Browse the repository at this point in the history