Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix release script to include commit hash #2400

Merged
merged 1 commit into from Jan 4, 2019

Conversation

Projects
None yet
2 participants
@Roasbeef
Copy link
Member

Roasbeef commented Jan 2, 2019

In this commit we update the release script to properly include the
commit hash in compiled binaries of lnd and lncli. In the future, we
should ditch the release script and extend the Makefile to support this
use case.

Fixes #2389.

build: fix release script to include commit hash
In this commit we update the release script to properly include the
commit hash in compiled binaries of lnd and lncli. In the future, we
should ditch the release script and extend the Makefile to support this
use case.

Fixes #2389.
@halseth

halseth approved these changes Jan 3, 2019

Copy link
Collaborator

halseth left a comment

Tested, LGTM

@Roasbeef Roasbeef merged commit 6589f68 into lightningnetwork:master Jan 4, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.005%) to 55.92%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.