Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netann: Add NANN subsystem logger #2445

Merged
merged 2 commits into from
Jan 11, 2019

Conversation

cfromknecht
Copy link
Contributor

In preparation for #2411, this PR introduces the NANN subsystem logger and tidies the imports in log.go

@cfromknecht cfromknecht added the logging Related to the logging / debug output functionality label Jan 9, 2019
@cfromknecht cfromknecht mentioned this pull request Jan 9, 2019
5 tasks
Copy link
Contributor

@wpaulino wpaulino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but don't see what we gain by breaking this up from the main PR?

@cfromknecht
Copy link
Contributor Author

Allows me to break up the body of #2411 if this is in place, gets rid of 2 of the 20 commits, and this import constantly breaks my rebasing on the watchtower series

Copy link
Contributor

@halseth halseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@halseth halseth merged commit 3c2b46e into lightningnetwork:master Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logging Related to the logging / debug output functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants