better error message if config file does not exist #2621
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I assume if one will want to run lnd without a config (which is strange) this push should not be merged
I assume if one will want to run lnd without a config (which is strange) this push should not be merged
Roasbeef
reviewed
Feb 11, 2019
cfromknecht
reviewed
Oct 5, 2020
Co-authored-by: Conner Fromknecht <conner@lightning.engineering>
|
@mrmanpew the current version fails to compile with this error: |
|
Maybe now? |
|
@cfromknecht is that ok? I don't understand this error message: |
|
The comment needs to be indented with a tab character, not 4 spaces. You can also locally run |
|
Ho man, what now? I've fixed the lint.. |
|
@lightninghelper, remember to re-request review from reviewers for your latest update |
1 similar comment
|
@lightninghelper, remember to re-request review from reviewers for your latest update |
|
Replaced by #6080 to speed up review process. Original commit author was preserved, thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I assume if one will want to run lnd without a config (which is strange) this push should not be merged