Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

channeldb+routing+discovery: reject zombie announcements #2777

Merged
merged 8 commits into from
Mar 28, 2019
Merged

channeldb+routing+discovery: reject zombie announcements #2777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a26a643
channeldb: remove unused buckets
wpaulino Mar 27, 2019
b780dfa
channeldb: add zombie edge index
wpaulino Mar 27, 2019
e98f4d6
channeldb: extend DeleteChannelEdge to mark edge as zombie
wpaulino Mar 27, 2019
c82d73a
channeldb+routing: extend edge lookup methods with zombie index check
wpaulino Mar 27, 2019
174645f
routing+server: expose DefaultChannelPruneExpiry
wpaulino Mar 27, 2019
23796d3
routing+discovery: extend ChannelGraphSource with zombie index methods
wpaulino Mar 27, 2019
44a01db
routing: expose VerifyChannelUpdateSignature function
wpaulino Mar 27, 2019
5cec451
discovery: reject announcements for known zombie edges
wpaulino Mar 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions channeldb/db.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,9 @@ func createChannelDB(dbPath string) error {
if _, err := edges.CreateBucket(channelPointBucket); err != nil {
return err
}
if _, err := edges.CreateBucket(zombieBucket); err != nil {
return err
}

graphMeta, err := tx.CreateBucket(graphMetaBucket)
if err != nil {
Expand Down
9 changes: 8 additions & 1 deletion channeldb/error.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
package channeldb

import "fmt"
import (
"errors"
"fmt"
)

var (
// ErrNoChanDBExists is returned when a channel bucket hasn't been
Expand Down Expand Up @@ -79,6 +82,10 @@ var (
// can't be found.
ErrEdgeNotFound = fmt.Errorf("edge not found")

// ErrZombieEdge is an error returned when we attempt to look up an edge
// but it is marked as a zombie within the zombie index.
ErrZombieEdge = errors.New("edge marked as zombie")

// ErrEdgeAlreadyExist is returned when edge with specific
// channel id can't be added because it already exist.
ErrEdgeAlreadyExist = fmt.Errorf("edge already exist")
Expand Down
Loading