[reliable payments] Move payment error deobfuscation to router #3063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halseth
force-pushed
the
router-error-deobfuscation
branch
2 times, most recently
from
d1dc602
to
8575d62
Compare
halseth
force-pushed
the
router-error-deobfuscation
branch
2 times, most recently
from
ba14744
to
77ffe6c
Compare
3 tasks
Roasbeef
requested changes
May 10, 2019
halseth
force-pushed
the
router-error-deobfuscation
branch
5 times, most recently
from
d9ccc34
to
80c2dfc
Compare
|
PTAL @Roasbeef |
cfromknecht
reviewed
May 14, 2019
There was a problem hiding this comment.
@halseth completed an initial pass, most everything looks good though i think there's a potential race between GetPaymentResult and removePendingPayment.
halseth
force-pushed
the
router-error-deobfuscation
branch
9 times, most recently
from
f4a6cd4
to
a3fbc87
Compare
joostjager
reviewed
May 16, 2019
halseth
force-pushed
the
router-error-deobfuscation
branch
2 times, most recently
from
ebcfe7b
to
7e552a0
Compare
cfromknecht
reviewed
May 16, 2019
|
needs rebase as well :) |
The switch satisfies this interface, and makes it easy to mock the send method from the router.
This commit moves the responsibility of generating a unique payment ID from the switch to the router. This will make it easier for the router to keep track of which HTLCs were successfully forwarded onto the network, as it can query the switch for existing HTLCs as long as the paymentIDs are kept. The router is expected to maintain a map from paymentHash->paymentID, such that they can be replayed on restart. This also lets the router check the status of a sent payment after a restart, by querying the switch for the paymentID in question.
We will later persist the fields necessary to decrypt a received error.
With the following commits, it'll become important to not resuse paymentIDs, since there is no way to tell whether the HTLC in question has already been forwarded and settled/failed. We clarify this in the SendHTLC comments, and alter the tests to not attempt to resend an HTLC with a duplicate payment ID.
This lets us distinguish an critical error from a actual payment result (success or failure). This is important since we know that we can only attempt another payment when a final result from the previous payment attempt is received.
We extract the session key such that we can later store it across restarts.
In this commit we move handing the deobfuscator from the router to the switch from when the payment is initiated, to when the result is queried. We do this because only the router can recreate the deobfuscator after a restart, and we are preparing for being able to handle results across restarts. Since the deobfuscator cannot be nil anymore, we can also get rid of that special case.
halseth
force-pushed
the
router-error-deobfuscation
branch
from
7e552a0
to
cd02c22
Compare
|
Rebased :) PTAL @joostjager @cfromknecht |
cfromknecht
approved these changes
May 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists of two important pieces of #2761:
Make
router<->switchinteraction asyncWe define
PaymentResultand the methodGetPaymentResultexposed by the
switch.This lets us distinguish an critical error from a actual payment result
(success or failure). This is important since we know that we can only
attempt another payment when a final result from the previous payment
attempt is received.
In order to achieve this we let the
routerhandling generatingpaymentIDs,since they are used to later query the
switchfor the final result.Move payment error deobfuscation
In this commit we move handing the deobfuscator from the router to the
switch from when the payment is initiated, to when the result is
queried.
We do this because only the router can recreate the deobfuscator after a
restart, and we are preparing for being able to handle results across
restarts.
Since the deobfuscator cannot be nil anymore, we can also get rid of
that special case.
Split off from #2761