chainreg: shutdown if backend node doesn't support taproot #6798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roasbeef
added
safety
Roasbeef
force-pushed
the
backend-must-taproot
branch
from
592af65
to
3a37ef3
Compare
yyforyongyu
requested changes
Aug 5, 2022
Roasbeef
force-pushed
the
backend-must-taproot
branch
from
3a37ef3
to
0718e5d
Compare
In this commit, we add a check during normal node construction to see if the backend node supports Taproot. If it doesn't, then we want to shutdown and force the user to take note. To check if the node supports Taproot, we'll first try the normal getblockchaininfo call. If this works, cool, then we can rely on the value. If it doesn't, then we'll fall back to the getdeploymentinfo call which was added in a recent version of bitcoind [1]. Newer versions of bitcoind might also have this call, and the getblockchaininfo call, but not actually populate the softforks field [2]. In this case, we'll fall back, and we also account for the case when the getblockchaininfo RPC is removed all together. [1]: bitcoin/bitcoin#23508 [2]: bitcoin/bitcoin#25114 Fixes lightningnetwork#6773
Roasbeef
force-pushed
the
backend-must-taproot
branch
from
0718e5d
to
492f8b6
Compare
bhandras
added a commit
to bhandras/loop
that referenced
this pull request
Oct 7, 2022
In this commit we bump the minimum LND version required to run loopd to v0.15.1-beta in order to ensure that the underlying chain backend supports taproot (lightningnetwork/lnd#6798)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, we add a check during normal node construction to see if
the backend node supports Taproot. If it doesn't, then we want to
shutdown and force the user to take note.
To check if the node supports Taproot, we'll first try the normal
getblockchaininfo call. If this works, cool, then we can rely on the
value. If it doesn't, then we'll fall back to the getdeploymentinfo call
which was added in a recent version of bitcoind 1. Newer versions of
bitcoind might also have this call, and the getblockchaininfo call, but
not actually populate the softforks field 2. In this case, we'll fall
back, and we also account for the case when the getblockchaininfo RPC is
removed all together.
Fixes #6773