-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add response to err #20
add response to err #20
Conversation
Looks awesome, I think this closes #18 too! Can you add a test for this? |
@clayreimann thanks for the tip, I added test and it got pass in my machine as well :-) |
BTW, we could close #18 as well when this PR gets merged :-) |
Hey @clayreimann did you forget to bump version and publish to NPM? |
Yes, yes I did. Just got on a plane but I'll try and get this done later |
Lol, not a hurry, I still can use my personal git link in |
Pushed just now. Let me know if it doesn't deploy. |
So sweet @clayreimann, 1.1.0 is working for me :-) |
I used the awesome module with react, and it works but just a flaw when I try to use superagent-promise in await/async syntax.
See the below:
Hence, I propose that exposing
response
at thee
./cc @lightsofapollo