Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate sampled flag #263

Merged
merged 4 commits into from
Oct 5, 2020
Merged

Propagate sampled flag #263

merged 4 commits into from
Oct 5, 2020

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented Sep 30, 2020 •
edited
Loading

Fixes #261

@ocelotl ocelotl changed the title WIP Propagate sampled flag Oct 5, 2020
@ocelotl ocelotl marked this pull request as ready for review October 5, 2020 03:08
@ocelotl ocelotl self-assigned this Oct 5, 2020
@kayousterhout
Copy link
Contributor

Do you need to set Sampled here (instead of always using true): https://github.com/lightstep/lightstep-tracer-go/blob/master/propagation_lightstep.go#L40

@ocelotl
Copy link
Contributor Author

ocelotl commented Oct 5, 2020

Do you need to set Sampled here (instead of always using true): https://github.com/lightstep/lightstep-tracer-go/blob/master/propagation_lightstep.go#L40

Right, fixed. 👍

codeboten
codeboten suggested changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, just one comment around one additional test that I think we should have.

tracer_test.go Show resolved Hide resolved
@ocelotl ocelotl requested a review from codeboten October 5, 2020 16:29
codeboten
codeboten approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ocelotl ocelotl merged commit 5fae746 into master Oct 5, 2020
@ocelotl ocelotl deleted the issue_261 branch October 5, 2020 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

Assignees

@ocelotl ocelotl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sampling decision propagation
3 participants
@ocelotl @kayousterhout @codeboten