handle errors/execptions when summarize sgfs files #534
Conversation
python/summarize_sgfs.py
Outdated
| game = sgf.Sgf_game.from_bytes(sgf_string) | ||
| winner = game.get_winner() | ||
| except: | ||
| print ("A sgf string is damaged, and its record has been skipped!") |
There was a problem hiding this comment.
This is not ideal, you should almost never try to catch all exceptions in python, since it will even catch the user pressing ctrl-c or trying to terminate the program. Instead, catch only the specific exception(s) that from_bytes will actually raise.
Additionally, this error message could be a bit more helpful. Ideally _add_a_single_sgf_string should be augmented to have a "debug_source" argument, which contains the file name and/or line number, so that the print message can display more helpful info to the user about trying to find where the problem is.
There was a problem hiding this comment.
Thanks! I just updated this based on the comment. I made it more specific on the error as value error. Since there will be a string passed into _add_a_single_sgf_string, the only non-terminating exception should be ValueError. The solution has been tested on the damaged files.
In addition, I also made the print out the error as a colored message so that people can see more clear on where the error from.
passed test on the damaged sgfs files