Fix #454 #550
Fix #454 #550
Conversation
|
Looks like this makes CI mad as it can't find Akka configs. I've tried re-starting those jobs and they fail with the same error, so probably not just flakes. Akka loads the default config through resources IIRC |
|
@lihaoyi Thanks for the quick reply. Didn't see them , when run the tests locally, because akka project test aren't run for 2.12. I think it the second overridden function is guilty for that. I'll let you know , when I fix it. |
|
Travis doesn't like me, two build failed complaining about github API rate limit. Looks like this failures aren't related to my changes and failed akka test is green now, so please review. BTW Since those tests randomly fail, maybe it makes sense to replace github api with something else or even to remove them. |
|
Yeah I just ignore the rate limited tests. They suck but they'll do until someone gets around to fixing/removing them. Feel free to send a PR to replace that API endpoint with some other |
|
|
||
| private def getURLFromFileDict(name: String) = { | ||
| val className = name.stripSuffix(".class").replace('/', '.') | ||
| newFileDict.find(_._1 == className) map { c => |
There was a problem hiding this comment.
Could this be replaced by newFileDict.get(className)? That will let it be O(1) rather than O(n) as the size of newFileDict grows
|
It's not easy being geen |
|
This should be published in the next unstable version if CI doesn't flake |
Fix #454. Ported from here. Not sure if put the test into the right place (or whether it needed at all)