Removes dependency on scalaz (#644) #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coursier no longer depends on scalaz as of 1.1.0-M4. Removing scalaz means smaller bundle size and keeping interpreter classpath more pristine.
| 'values - check212(load(instance.values _), "Map.scala", "def values") | ||
| 'mapAccumL - check212(load(instance.mapAccumL _), "Map.scala", "def mapAccumL") | ||
| 'split - check212(load(instance.split _), "Map.scala", "def split") | ||
| } |
There was a problem hiding this comment.
These tests could probably be kept by adding a dependency on scalaz, in the repl module, only in tests.
|
I'm fine with whatever, either merging this now or waiting for 1.1.0-FINAL. @alexarchambault feel free to merge (or not) at your leisure |
|
I need to admit that I ran tests only on Scala 2.11.9 locally. It would seem that the line introduced by the latest change is redundant. I'm not sure why it makes it work on 2.12. |
|
@lihaoyi Do you have an opinion about 7104f12 (#830 (comment))? I'm ok to merge else. |
|
@alexarchambault Let's just leave it in for now, can't do any harm |
|
go ahead and merge :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coursier no longer depends on scalaz as of 1.1.0-M4. Removing scalaz
means smaller bundle size and keeping interpreter classpath more
pristine.