New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify ParsingRun error reporting functions #276
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t is present to prevent backtracking
lihaoyi
force-pushed
the
simplify-parsing-run
branch
from
March 4, 2023 21:42
ea931a2
to
a4516bf
Compare
lihaoyi
force-pushed
the
simplify-parsing-run
branch
from
March 5, 2023 07:09
a8f0067
to
1a5820d
Compare
lihaoyi
force-pushed
the
simplify-parsing-run
branch
from
March 7, 2023 06:02
7892ab8
to
ecebc6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
def aggregateMsg
withreportAggregateMsg
anddef aggregateTerminal
withdef reportTerminalMsg
, andfailureGroupAggregate
andfailureTerminalAggregate
withaggregateParserMsgs
andterminalParserMsgs
, for consistency withdef longAggregateMsg
anddef longTerminalMsg
Tighted up error reporting logic to avoid parse failures that happened earlier when
index < traceIndex
from being shown in the finalfailureAggregates
output, which is intended to only show parse failures that occurred whenindex == traceIndex
(with associated tests)Consolidated all
def report*Msg
methods into a singledef reportParseMsg0
to avoid unnecessary code duplication and divergenceAdd some implicit constructors for
Msgs
to clean up callsitesMoved long explanation of how error reporting works to the readme docsite, and fixed
sbt readme/run
to work with new version of MillInline
&
and!
operators on Scala 3 for perf