Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify ParsingRun error reporting functions #276

Merged
merged 50 commits into from Mar 7, 2023
Merged

Conversation

lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented Mar 4, 2023

  • Rename def aggregateMsg with reportAggregateMsg and def aggregateTerminal with def reportTerminalMsg, and failureGroupAggregate and failureTerminalAggregate with aggregateParserMsgs and terminalParserMsgs, for consistency with def longAggregateMsg and def longTerminalMsg

  • Tighted up error reporting logic to avoid parse failures that happened earlier when index < traceIndex from being shown in the final failureAggregates output, which is intended to only show parse failures that occurred when index == traceIndex (with associated tests)

  • Consolidated all def report*Msg methods into a single def reportParseMsg0 to avoid unnecessary code duplication and divergence

  • Add some implicit constructors for Msgs to clean up callsites

  • Moved long explanation of how error reporting works to the readme docsite, and fixed sbt readme/run to work with new version of Mill

  • Inline & and ! operators on Scala 3 for perf

@lihaoyi lihaoyi merged commit f40fe81 into master Mar 7, 2023
@lefou lefou added this to the 3.0.0 milestone Mar 7, 2023
@lolgab lolgab deleted the simplify-parsing-run branch February 12, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants