Configure Idea project generator per module #458
Conversation
|
I'd be happy just hard-coding the intellij project generation flag inside |
|
If some day we generalize IntelliJ project generation to work for other arbitrary modules (python, js, ...) we can move the flag then |
|
What about "grouping" idea related def's by |
|
Currently idea-related defs aren't standalone; they live mixed in with the JavaModule defs, as bits and pieces refactored out to be conveniently consumed by intellij. Maybe in future when we have more idea-related stuff we can extract it out into it's own trait |
* Sketched how to skip some projects from Idea project generator * Better trait comment * Moved skipIdea flag into JavaModule
* Sketched how to skip some projects from Idea project generator * Better trait comment * Moved skipIdea flag into JavaModule
| for((path, mod) <- modules) | ||
| yield moduleName(path) | ||
| modules | ||
| .filter(!_._2.skipIdea) |
There was a problem hiding this comment.
This could use a collect instead to avoid iterating over the modules twice
.collect {
case (path, mod) if !mod.skipIdea => moduleName(path)
}
This PR is a first sketch how to skip some modules in Idea project generator.
The motivation is simple:
This is a quickly hacked PR to sketch one possible solution to tackle the need to customize project generation. I'm open for input / change requests. If we can reach a consensus about the general direction, we can beautify, e.g. move the
IdeaConfigModuleinto it's own file. Also tests would be nice, but I'm not familiar with the integration test setup of mill yet.