Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed CoursierModule.repositories to a Task #976

Merged
merged 2 commits into from Nov 12, 2020

Conversation

lefou
Copy link
Member

@lefou lefou commented Oct 16, 2020

This should allow to use environment variables e.g. for repository authentication. See https://gitter.im/lihaoyi/mill?at=5f872eeccdb04d1ea081cd4f and following discussion.

@lefou lefou marked this pull request as ready for review November 3, 2020 16:52
Copy link
Member

@lihaoyi lihaoyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me

@lefou lefou merged commit 9c881a8 into com-lihaoyi:master Nov 12, 2020
@lefou lefou added this to the after 0.8.0 milestone Nov 12, 2020
@lefou lefou deleted the repos-task branch November 12, 2020 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants