Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draw hollow cursor when terminal not focused #29

Closed
lihop opened this issue Nov 24, 2020 · 0 comments · Fixed by #98
Closed

Draw hollow cursor when terminal not focused #29

lihop opened this issue Nov 24, 2020 · 0 comments · Fixed by #98
Labels
enhancement New feature or request

Comments

@lihop
Copy link
Owner

lihop commented Nov 24, 2020

Currently the terminal always draws the cursor as a block.
We should follow xterm and draw a hollow cursor when Terminal.has_focus() is false.
i.e:

  • Terminal.has_focus() == true:
    2020-11-24-153911_74x29_scrot

  • Terminal.has_focus() == false:
    2020-11-24-154015_76x28_scrot
@lihop lihop added the enhancement New feature or request label Nov 24, 2020
lihop added a commit that referenced this issue Jul 22, 2021
@lihop
Terminal updates
dced761 
- Add support for blink.
- Make cursor hollow when terminal Control not focused. Closes #29.
- Allow theme inheritance.
lihop added a commit that referenced this issue Jul 22, 2021
@lihop
Terminal updates
1a3dbd9 
- Add support for blink.
- Make cursor hollow when terminal Control not focused. Closes #29.
- Allow theme inheritance.
lihop added a commit that referenced this issue Jul 23, 2021
@lihop
Terminal updates
c97b1a0 
- Add support for blink.
- Make cursor hollow when terminal Control not focused. Closes #29.
- Allow theme inheritance.
@lihop lihop mentioned this issue Jan 14, 2023
Closed
lihop added a commit that referenced this issue Apr 28, 2024
@lihop
feat(term): make cursor hollow when un-focused
6cc6e53 
Closes #29.
@lihop lihop mentioned this issue Apr 28, 2024
Merged
@lihop lihop closed this as completed in #98 Apr 28, 2024
lihop added a commit that referenced this issue Apr 28, 2024
@lihop
feat(term): make cursor hollow when un-focused
4c4e61c 
Closes #29.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(term): make cursor hollow when un-focused lihop/godot-xterm
1 participant
@lihop