Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Godot 4] Highlight editor terminal border on focus #68

Closed
lihop opened this issue Jan 14, 2023 · 1 comment
Closed

[Godot 4] Highlight editor terminal border on focus #68

lihop opened this issue Jan 14, 2023 · 1 comment
Labels
enhancement New feature or request godot 4
Milestone

Comments

@lihop
Copy link
Owner

lihop commented Jan 14, 2023

Draw an outline around the editor terminal when it is focused.

blue-border

Although this feature is currently lacking in GodotXterm, the bright blue border of Godot 4's default theme makes the lack of this feature more obvious.

Implementing #29 would also help indicate that the editor terminal is or isn't focused.

@lihop lihop added enhancement New feature or request godot 4 labels Jan 14, 2023
@lihop lihop added this to the Godot 4.0 milestone Jan 14, 2023
lihop added a commit that referenced this issue Apr 14, 2024
lihop added a commit that referenced this issue Apr 14, 2024
@lihop
Copy link
Owner Author

lihop commented Apr 28, 2024

Closing in favour of only having a hollow cursor (#29) as this is implemented in #98.
The hollow cursor only behaviour is consistent with the script editor and VSCode.
I tried adding a bright blue border, but found it overly distracting.

focus-shift

@lihop lihop closed this as completed Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request godot 4
Projects
None yet
Development

No branches or pull requests

1 participant