[2.x] Add events

[alexislefebvre]

I took inspiration from FOSUserBundle: https://github.com/FriendsOfSymfony/FOSUserBundle/blob/8bb87890cbd872c870f7bd146922906f6e8ddf5c/FOSUserEvents.php#L26

TODO:

• Remove ObjectManager, ReferenceRepository and AbstractExecutor from the events? Users could inject these services in their listeners
• Declare a listener and set PHPUnit mock to ensure that the listeners are called
• Restore the ReferenceRepository in the relevant event, as requested in [RFC] Post Fixtures Database restore #27?
• Move symfony/event-dispatcher and symfony/event-dispatcher-contracts in require instead of require-dev

[lsmith77]

I guess this would be the basis for a 2.x release?

[lsmith77]

@stof since you seem to have authored similar changes in FOSUserBundle, can you also have a look here?

[alexislefebvre]

@lsmith77

I guess this would be the basis for a 2.x release?

This PR doesn't add any BC break, so this can be merged as is. But we will have duplicated lines about events:

LiipTestFixturesBundle/src/Services/DatabaseTools/MongoDBDatabaseTool.php

Lines 72 to 74 in d140253

	$event = new FixtureBackupEvent($backupService->getBackupFilePath());
	$this->dispatchEvent($event, LiipTestFixturesEvents::PRE_FIXTURE_BACKUP_RESTORE);
	$this->testCase->preFixtureBackupRestore($this->om, $referenceRepository, $backupService->getBackupFilePath());

Then we could remove $this->testCase->preFixtureBackupRestore(…) and similar calls for the 2.x version.

I would like to implement #26 in order to provide a 2.x version that work without Trait too.

[lsmith77]

do we even want to still care about <- 4.3? https://symfony.com/releases

[lsmith77]

or would not including this create a BC break?

[stof]

well, currently, the composer.json says it supports Symfony 3.4+.

[alexislefebvre]

I would prefer to support Symfony 3.4 as long as it doesn't cause too many trouble.

[lsmith77]

ok, fine for me!

[alexislefebvre]

Finally, I changed my mind and removed support of Symfony < 4.4. Symfony 3.4 will only get security fixes now, I think no one would upgrade that bundle while keeping a legacy version of Symfony.

[lsmith77]

yeah I am fine bumping that to 4.4

…

On Tue, 19 Jan 2021 at 11:25, Christophe Coevoet ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/Services/DatabaseTools/AbstractDatabaseTool.php <#81 (comment)> : > @@ -221,4 +230,22 @@ protected function getCacheMetadataParameter() return $this->container->hasParameter(self::CACHE_METADATA_PARAMETER_NAME) && false !== $this->container->getParameter(self::CACHE_METADATA_PARAMETER_NAME); } + + /** + * Compatibility layer for Symfony <= 4.3 well, currently, the composer.json says it supports Symfony 3.4+.

-- regards, Lukas

[lsmith77]

I suggest we create a new 2.x branch and point this PR at 2.x

wdyt?

[lsmith77]

LGTM aside from the small CS issue I noticed

[alexislefebvre]

Thanks for the review @lsmith77 ! I fixed the issue and will merge once CI is finished.