Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.2 deprecations #173

Closed
evs-xsarus opened this issue Sep 5, 2023 · 5 comments
Closed

PHP 8.2 deprecations #173

evs-xsarus opened this issue Sep 5, 2023 · 5 comments

Comments

@evs-xsarus
Copy link
Contributor

Could these be fixed:

evs@XSA-LT2020003:~/sites/xsm_version-bump (master) $ p82 RMT release

Deprecated: Using ${var} in strings is deprecated, use {$var} instead in /sites/xsm_version-bump/vendor/liip/rmt/src/Liip/RMT/Application.php on line 159

Call Stack:
    0.0004     664360   1. {main}() /sites/xsm_version-bump/RMT:0
    0.0005     665480   2. require('/sites/xsm_version-bump/vendor/liip/rmt/command.php') /sites/xsm_version-bump/RMT:4
    0.0025     818616   3. Composer\Autoload\ClassLoader->loadClass($class = 'Liip\\RMT\\Application') /sites/xsm_version-bump/vendor/liip/rmt/command.php:3
    0.0026     818728   4. Composer\Autoload\{closure:/sites/xsm_version-bump/vendor/composer/ClassLoader.php:575-577}($file = '/sites/xsm_version-bump/vendor/composer/../liip/rmt/src/Liip/RMT/Application.php') /sites/xsm_version-bump/vendor/composer/ClassLoader.php:427


Deprecated: Creation of dynamic property Liip\RMT\Config\Handler::$rawConfig is deprecated in /sites/xsm_version-bump/vendor/liip/rmt/src/Liip/RMT/Config/Handler.php on line 21

Call Stack:
    0.0004     664360   1. {main}() /sites/xsm_version-bump/RMT:0
    0.0005     665480   2. require('/sites/xsm_version-bump/vendor/liip/rmt/command.php') /sites/xsm_version-bump/RMT:4
    0.0052    1051944   3. Liip\RMT\Application->__construct() /sites/xsm_version-bump/vendor/liip/rmt/command.php:3
    0.0097    1928816   4. Symfony\Component\Console\Command\Command->__construct($name = ???) /sites/xsm_version-bump/vendor/liip/rmt/src/Liip/RMT/Application.php:53
    0.0098    1928976   5. Liip\RMT\Command\ReleaseCommand->configure() /sites/xsm_version-bump/vendor/symfony/console/Command/Command.php:137
    0.0098    1928976   6. Liip\RMT\Command\BaseCommand->loadContext() /sites/xsm_version-bump/vendor/liip/rmt/src/Liip/RMT/Command/ReleaseCommand.php:34
    0.0136    2309712   7. Liip\RMT\Config\Handler->__construct($rawConfig = ['_default' => ['vcs' => 'git', 'prerequisites' => [...], 'version-generator' => 'semantic', 'version-persister' => [...], 'pre-release-actions' => [...], 'post-release-actions' => [...]], 'master' => ['version-generator' => 'semantic', 'version-persister' => [...], 'pre-release-actions' => [...]]], $projectRoot = '/sites/xsm_version-bump') /sites/xsm_version-bump/vendor/liip/rmt/src/Liip/RMT/Command/BaseCommand.php:74


Deprecated: Creation of dynamic property Liip\RMT\Config\Handler::$projectRoot is deprecated in /sites/xsm_version-bump/vendor/liip/rmt/src/Liip/RMT/Config/Handler.php on line 22

Call Stack:
    0.0004     664360   1. {main}() /sites/xsm_version-bump/RMT:0
    0.0005     665480   2. require('/sites/xsm_version-bump/vendor/liip/rmt/command.php') /sites/xsm_version-bump/RMT:4
    0.0052    1051944   3. Liip\RMT\Application->__construct() /sites/xsm_version-bump/vendor/liip/rmt/command.php:3
    0.0097    1928816   4. Symfony\Component\Console\Command\Command->__construct($name = ???) /sites/xsm_version-bump/vendor/liip/rmt/src/Liip/RMT/Application.php:53
    0.0098    1928976   5. Liip\RMT\Command\ReleaseCommand->configure() /sites/xsm_version-bump/vendor/symfony/console/Command/Command.php:137
    0.0098    1928976   6. Liip\RMT\Command\BaseCommand->loadContext() /sites/xsm_version-bump/vendor/liip/rmt/src/Liip/RMT/Command/ReleaseCommand.php:34
    0.0136    2309712   7. Liip\RMT\Config\Handler->__construct($rawConfig = ['_default' => ['vcs' => 'git', 'prerequisites' => [...], 'version-generator' => 'semantic', 'version-persister' => [...], 'pre-release-actions' => [...], 'post-release-actions' => [...]], 'master' => ['version-generator' => 'semantic', 'version-persister' => [...], 'pre-release-actions' => [...]]], $projectRoot = '/sites/xsm_version-bump') /sites/xsm_version-bump/vendor/liip/rmt/src/Liip/RMT/Command/BaseCommand.php:74
@jeanmonod
Copy link
Member

Probably related to a recent version of PHP. Can you bump your version number here? Thanks

@jeanmonod
Copy link
Member

Oh, I just saw the issue title 😅
I will have a look

@jeanmonod
Copy link
Member

I just realized I still don't have project with PHP 8.2 running. Are you able to provide a pull request?

evs-xsarus added a commit to evs-xsarus/RMT that referenced this issue Sep 8, 2023
@evs-xsarus
Copy link
Contributor Author

See #174

jeanmonod added a commit that referenced this issue Sep 11, 2023
Ticket #173: prevent PHP 8.2 deprecation warnings.
@jeanmonod
Copy link
Member

Fixed in version 1.7.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants