Registration enhancement #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnkken
approved these changes
Dec 2, 2019
nwingt
force-pushed
the
feature/registration
branch
from
5037e07
to
4f76bc4
Compare
nnkken
reviewed
Dec 2, 2019
app/i18n/en.json
Outdated
| @@ -38,7 +38,8 @@ | |||
| "shareYourAddress": "Share your address" | |||
| }, | |||
| "RegistrationScreen": { | |||
| "likerIdLabel": "Create your Liker ID (7 or more characters)" | |||
| "likerIdHint": "Allow 7-20 lowercase letters, dash and underscore only", | |||
nwingt
force-pushed
the
feature/registration
branch
from
cc8f8af
to
f0bb7f5
Compare
|
how about also call check username API? |
nnkken
approved these changes
Dec 2, 2019
nwingt
force-pushed
the
feature/registration
branch
from
f0bb7f5
to
112cdba
Compare
|
@williamchong007 I think we can put this to next sprint |
williamchong
reviewed
Dec 3, 2019
| @@ -42,7 +42,8 @@ | |||
| }, | |||
| "RegistrationScreen": { | |||
| "likerIdHint": "只允許7至20位小寫英文字母、數字、「-」及「_」字元", | |||
| "likerIdLabel": "創建 Liker ID" | |||
| "likerIdLabel": "創建 Liker ID", | |||
| "shouldSignInOnDesktop": "請在電腦上登入 http://like.co 後再試一遍" | |||
There was a problem hiding this comment.
Do we want to mention email exists in the message?
There was a problem hiding this comment.
This is the body message, and the title is "email exists"
williamchong
approved these changes
Dec 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.