💄 [_classId/] Add <NFTBookEditionCover/> #1136
Conversation
src/mixins/nft.js
Outdated
| const style = { | ||
| spineColor1: edition.spineColor1 || '#EBEBEB', | ||
| spineColor2: edition.spineColor2 || '#9B9B9B', | ||
| themeColor: edition.themeColor || defaultThemeColor[index], |
There was a problem hiding this comment.
I don't think there should be a default theme color indexes, since there is no constraint in pricing tiers that state they must have increasing rarity
There was a problem hiding this comment.
I think it's unrelated to rarity, just that there can be a clear distinction on the UI.
There was a problem hiding this comment.
Hmm what do we expect to see if there is more than 3 edition?
Also what is the use of defaultEdition ?
There was a problem hiding this comment.
-
@nwingt Do you think we should keep defaultThemeColor, or do you have any other suggestions?
-
defaultEditionis to ensure that listings in the secondary market won't break the UI.
There was a problem hiding this comment.
But the info of the defaultEdition would be wrong on production for any book with listing but without a price
Can we just the ui component we don't have price info on?
There was a problem hiding this comment.
If we are to keep defaultThemeColor, index % defaultThemeColor.length should be used
AuroraHuang22
force-pushed
the
feature/stripe
branch
from
cf278cc
to
aeb9a1f
Compare
2023-06-19.10.05.37.mov