[TAS-158] ✨ Revamp index page #1288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwingt
added a commit
that referenced
this pull request
Aug 8, 2023
nwingt
added a commit
that referenced
this pull request
Aug 8, 2023
nwingt
added a commit
that referenced
this pull request
Aug 10, 2023
nwingt
added a commit
that referenced
this pull request
Aug 10, 2023
nwingt
added a commit
that referenced
this pull request
Aug 11, 2023
nwingt
force-pushed
the
feature/index-revamp
branch
from
082f491
to
d177286
Compare
nwingt
added a commit
that referenced
this pull request
Aug 16, 2023
nwingt
added a commit
that referenced
this pull request
Aug 17, 2023
nwingt
added a commit
that referenced
this pull request
Aug 17, 2023
nwingt
force-pushed
the
feature/index-revamp
branch
from
4b86a18
to
d177286
Compare
nwingt
added a commit
that referenced
this pull request
Aug 18, 2023
nwingt
added a commit
that referenced
this pull request
Aug 18, 2023
nwingt
added a commit
that referenced
this pull request
Aug 18, 2023
nwingt
added a commit
that referenced
this pull request
Aug 18, 2023
nwingt
added a commit
that referenced
this pull request
Aug 19, 2023
williamchong
requested changes
Aug 21, 2023
src/pages/index.vue
Outdated
| @@ -1457,10 +1457,15 @@ export default { | |||
| }, | |||
| }, | |||
| mounted() { | |||
| window.addEventListener('resize', this.handleResize); | |||
| this.resizeListener = window.addEventListener('resize', this.handleResize); | |||
There was a problem hiding this comment.
Should define resizeListener in data?
There was a problem hiding this comment.
I think no need to put it in data for reactivity
There was a problem hiding this comment.
Best to define it somewhere clearly as a class atteibute though
src/pages/index.vue
Outdated
| this.handleResize(); | ||
| this.animate(); | ||
| }, | ||
| beforeDestroy() { | ||
| if (this.resizeListener) { | ||
| window.removeEventListener(this.resizeListener); |
There was a problem hiding this comment.
Best to set this.resizeListener as null after removing it
nwingt
added a commit
that referenced
this pull request
Aug 22, 2023
williamchong
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.