🔒 Support state in oauth login, add configs, and fix some minor bugs #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🏗 Add firebase cloud function
🎨 Clean up oauth code and move most config to server
nnkken
reviewed
Mar 8, 2019
src/util/api/index.js
Outdated
| @@ -16,3 +16,4 @@ export const getFetchUserArticlesAPI = user => `/api/reader/user/${user}`; | |||
| export const getOAuthURL = () => | |||
| `${LIKE_CO_URL_BASE}/in/oauth?client_id=${CLIENT_ID}&redirect_uri=${OAUTH_REDIRECT_URI}&scope=read%3Alike.info`; | |||
| export const getOAuthCallbackAPI = authCode => `/api/users/login`; | |||
| export const getLoginStatus = authCode => `/api/users/self`; | |||
There was a problem hiding this comment.
because axios is outside, so cannot put it into payload here
maybe should put axios back inside here?
There was a problem hiding this comment.
How about this?
export const getLoginStatus = () => `/api/users/self`;There was a problem hiding this comment.
i think corrected in later commits in this PR
nnkken
reviewed
Mar 8, 2019
src/server/api/util/api.js
Outdated
| const getOAuthURL = state => | ||
| `${LIKE_CO_URL_BASE}/in/oauth?client_id=${LIKE_CO_CLIENT_ID}&redirect_uri=${OAUTH_REDIRECT_URI}&scope=read%3Alike.info&state=${state}`; | ||
| const getOAuthCallbackAPI = (authCode, state) => | ||
| `${LIKE_CO_URL_BASE}/api/oauth/access_token?client_id=${LIKE_CO_CLIENT_ID}&client_secret=${LIKE_CO_CLIENT_SECRET}&grant_type=authorization_code&redirect_uri=${OAUTH_REDIRECT_URI}&auth_code=${authCode}&state=${state}`; |
There was a problem hiding this comment.
state is not needed in access token request
👌 Don't send state when getting access token with authCode
nnkken
approved these changes
Mar 8, 2019
williamchong
pushed a commit
that referenced
this pull request
Dec 6, 2023
* 💄 Display gift info on claim page * 🎨 Wrap download section into canViewContentDirectly
williamchong
pushed a commit
that referenced
this pull request
Dec 7, 2023
williamchong
pushed a commit
that referenced
this pull request
Dec 7, 2023
williamchong
added a commit
that referenced
this pull request
Dec 13, 2023
* 💄 Add gift dialog in book * 💄 Add gift success page * 💄 Add gift message in claim page * 💄 Hide gift button for free book * 💄 Update GiftDialog UI * 💄 Display gift info on claim page (#6) * 💬 Update gift related text * 💬 Update book gift dialog placeholder Co-authored-by: Wei-Jun Hung <33746295+WeiJun0827@users.noreply.github.com> * 💩 Block LIKE book payment for gift --------- Co-authored-by: AuroraHuang22 <aurora90376@gmail.com> Co-authored-by: AuroraHuang22 <75730405+AuroraHuang22@users.noreply.github.com> Co-authored-by: Wei-Jun Hung <33746295+WeiJun0827@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.