Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolver.resolve(with: Promise) handles cancellation incorrectly #54

Closed
lilyball opened this issue Jul 17, 2020 · 0 comments
Closed

Resolver.resolve(with: Promise) handles cancellation incorrectly #54

lilyball opened this issue Jul 17, 2020 · 0 comments
Labels
bug Something isn't working
Milestone
v1.4.0

Comments

@lilyball
Copy link
Owner

This method is documented as propagating cancellation upwards. The current implementation means if the receiver is asked to cancel, it immediately asks the upstream promise to cancel too. What it should do is propagate cancellation like the built-in promise children do. In effect, it should convert the receiver into a child of the given promise.
@lilyball lilyball added the bug Something isn't working label Jul 17, 2020
@lilyball lilyball added this to the Next milestone Jul 21, 2020
lilyball added a commit that referenced this issue Jul 26, 2020
@lilyball
Fix cancellation propagation of resolve(with:) and flatMap
f880cb8 
Previously it was requesting cancellation of the upstream promise
immediately even if it hadn't yet sealed or had other registered
callbacks.

Fixes #54.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v1.4.0
Development

No branches or pull requests
1 participant
@lilyball