Rearrange code to avoid RDKit, Psi4 and QCFractal where possible #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilyminium
force-pushed
the
remove-hard-deps
branch
3 times, most recently
from
041582c
to
8e968bc
Compare
lilyminium
force-pushed
the
remove-hard-deps
branch
4 times, most recently
from
b9ce683
to
6da051c
Compare
lilyminium
force-pushed
the
remove-hard-deps
branch
3 times, most recently
from
b1c0ac8
to
a3ab851
Compare
|
This pull request fixes 1 alert when merging a3ab851 into 0bca066 - view on LGTM.com fixed alerts:
|
lilyminium
force-pushed
the
remove-hard-deps
branch
from
a3ab851
to
113c64d
Compare
lilyminium
changed the title
|
This pull request fixes 1 alert when merging 113c64d into 0bca066 - view on LGTM.com fixed alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Although RDKit, Psi4 and QCFractal remain crucial dependencies for full functionality, they are not typically available on Pypi. Psi4 is also not on conda-forge and therefore somewhat hard to include in a conda recipe.
Changes made
Checklist