Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add __init__ signature to Model #79

Merged
merged 4 commits into from
Mar 5, 2022
Merged

Add __init__ signature to Model #79

merged 4 commits into from
Mar 5, 2022

Conversation

lilyminium
Copy link
Owner

Description

Fixes #78

Changes made

  • Adds __init__ method to Model that gets magically signatured by MetaModel

Checklist

  • Tagged issue being addressed
  • Tests
  • Documentation
  • Changelog

@lgtm-com
Copy link

lgtm-com bot commented Mar 5, 2022

This pull request introduces 4 alerts when merging 85ffa8c into d134852 - view on LGTM.com

new alerts:

  • 2 for `__init__` method calls overridden method
  • 1 for First parameter of a method is not named 'self'
  • 1 for Unused import

@codecov
Copy link

codecov bot commented Mar 5, 2022

Codecov Report

Merging #79 (9d7a3ae) into master (d134852) will increase coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head 9d7a3ae differs from pull request most recent head 499bb90. Consider uploading reports for the commit 499bb90 to get more accurate results

@lgtm-com
Copy link

lgtm-com bot commented Mar 5, 2022

This pull request introduces 4 alerts when merging c5ed584 into d134852 - view on LGTM.com

new alerts:

  • 2 for First parameter of a method is not named 'self'
  • 1 for Unused import
  • 1 for `__init__` method calls overridden method

@lgtm-com
Copy link

lgtm-com bot commented Mar 5, 2022

This pull request introduces 3 alerts when merging 9d7a3ae into d134852 - view on LGTM.com

new alerts:

  • 2 for First parameter of a method is not named 'self'
  • 1 for `__init__` method calls overridden method

@lilyminium lilyminium merged commit 6f63fc5 into master Mar 5, 2022
@lilyminium lilyminium deleted the fix-init-signature branch March 5, 2022 06:22
@lgtm-com
Copy link

lgtm-com bot commented Mar 5, 2022

This pull request introduces 3 alerts when merging 499bb90 into d134852 - view on LGTM.com

new alerts:

  • 2 for First parameter of a method is not named 'self'
  • 1 for `__init__` method calls overridden method

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Function signatures not visible
1 participant