Implement starting instances from a HTTP URL #276
Conversation
Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
|
Thanks! |
| return nil, err | ||
| } | ||
| defer resp.Body.Close() | ||
| yBytes, err = io.ReadAll(resp.Body) |
There was a problem hiding this comment.
Should check body size before calling ReadAll
There was a problem hiding this comment.
Sorry for jumping the gun on merging already 😞
There was a problem hiding this comment.
Good call, hopefully it would return an error in that case ?
There was a problem hiding this comment.
Just used the https://pkg.go.dev/net/http sample code
There was a problem hiding this comment.
We can use https://pkg.go.dev/io#LimitedReader and it raises io.EOF when it reaches the limit (e.g., 1MB).
We should wrap the io.EOF error with a human-readable text.
There was a problem hiding this comment.
ah, so it was limit "protection" rather than looking for zero bytes
There was a problem hiding this comment.
but wouldn't the same thing happen with a local file as well ?
yBytes, err = os.ReadFile(arg)
Follow-up to `Implement starting instances from a HTTP URL ` (#276)
Closes #237