Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat every ext_storage_get result as Optional<any> #39

Closed
failfmi opened this issue Feb 13, 2023 · 0 comments · Fixed by #43
Closed

Treat every ext_storage_get result as Optional<any> #39

failfmi opened this issue Feb 13, 2023 · 0 comments · Fixed by #43
Assignees
@failfmi
Labels
enhancement New feature or request
Milestone
Phase 1 - M2 - Ru...

Comments

@failfmi
Copy link
Collaborator

failfmi commented Feb 13, 2023

Currently in the codebase, whenever ext_storage_get is called the length of the result is checked whether it is > 1 and then the value is decoded. Refactor storage.get to treat the result value as option type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@failfmi failfmi

Labels
enhancement New feature or request
Projects
Gosemble - Polkadot Runtimes
Status: ✅ Done
Milestone
Phase 1 - M2 - Runtime APIs, Storage,...
Development

Successfully merging a pull request may close this issue.

refactor(storage/get): parse option and add generic get/take LimeChain/gosemble
1 participant
@failfmi