-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a build system (was: Why does py3 need to be compile without SIGALTSTACK?) #107
Comments
This issue is linked in the readme: https://code.google.com/p/go/issues/detail?id=5287 |
The bold "must" in the readme links to the issue number with more details (see the issue it was merged with too). In short, Python or other C code messing with signal handling screws Go's signal handling up or some such. While python's signal handlers can be disabled at runtime, the code calling sigaltstack cannot last I poked around in the python sources. Hence the custom compilation step. I'm open for suggestions if someone knows of another way to deal with it. We might just want to create a build system (I prefer cmake personally) that pulls in all required dependencies, patches them (as needed) and then builds them. That would help with #104 and #105 too. |
Oh, sorry, guess I should read things better. I think a build system would be great, but I'm no good with make. |
Isn't it better to internalize Python and Go then? I think it's a bit too much to require developers to use a non-standard Python and a dev-channel Go. |
Feel free to be the one to submit the pull request. |
I was just thinking of trying to put together some form of build system. I'll give it a go this weekend. |
Changed the title |
Thanks! |
@ryanwersal did you end up with anything? Otherwise I'd like to kick this one off myself as it appears to be blocking people from aiding the project in more productive ways than being stuck at the getting started stage. |
@quarnster Regretfully I have had difficulty both finding the time and trying to make headway with CMake this last week as I'm not very familiar with it. Sorry for the hold up. At this point it is likely best left in your hands. |
@ryanwersal No worries. Assigning myself here |
Unassigning myself as I might not get a chance to look at this again for a while. |
Travis is now using the build system, and it appears to function for me on OSX, linux and windows. Let's open up separate issue numbers for specific issues with the build system. Closing this one. |
Nice! thanks! |
I feel like that's another barrier to entry for development. Do we know why this flag needs to be unset? Is there anything we can do to make it so this isn't necessary?
The text was updated successfully, but these errors were encountered: