Correct and enhance collection slicing #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twidi
force-pushed
the
feature/twidi/correct-and-enhance-slicing
branch
from
c429189
to
51d04c5
Compare
twidi
force-pushed
the
feature/twidi/correct-and-enhance-slicing
branch
from
51d04c5
to
3c6ea69
Compare
|
Auto-reviewed and approved |
twidi
force-pushed
the
feature/twidi/in__suffix_in_indexes
branch
from
688bfb0
to
1c0482c
Compare
twidi
changed the base branch from
feature/twidi/in__suffix_in_indexes
to
develop
Some slicing were not managed at all, retrieving the wrong number of data. It is now corrected, with also more cases where we try to limit the data returned by redis To be sure that the data is always correctly returned, in the tests we compare the result of slicing a collection to the same slicing of a normal python list. Same for indexing (both in `__getitem__`)
Not supported in python 2.6 but now we support only python >=2.7
twidi
force-pushed
the
feature/twidi/correct-and-enhance-slicing
branch
from
3c6ea69
to
e21a27d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some slicing were not managed at all, retrieving the wrong number of
data.
It is now corrected, with also more cases where we try to limit the data
returned by redis
To be sure that the data is always correctly returned, in the tests we
compare the result of slicing a collection to the same slicing of a
normal python list. Same for indexing (both in
__getitem__)PS: depnds on #109